Commit 47f753c1 authored by Tan Tee Min's avatar Tan Tee Min Committed by David S. Miller
Browse files

net: stmmac: disable Split Header (SPH) for Intel platforms 



Based on DesignWare Ethernet QoS datasheet, we are seeing the limitation
of Split Header (SPH) feature is not supported for Ipv4 fragmented packet.
This SPH limitation will cause ping failure when the packets size exceed
the MTU size. For example, the issue happens once the basic ping packet
size is larger than the configured MTU size and the data is lost inside
the fragmented packet, replaced by zeros/corrupted values, and leads to
ping fail.

So, disable the Split Header for Intel platforms.

v2: Add fixes tag in commit message.

Fixes: 67afd6d1("net: stmmac: Add Split Header support and enable it in XGMAC cores")
Cc: <stable@vger.kernel.org> # 5.10.x
Suggested-by: default avatarOng, Boon Leong <boon.leong.ong@intel.com>
Signed-off-by: default avatarMohammad Athari Bin Ismail <mohammad.athari.ismail@intel.com>
Signed-off-by: default avatarWong Vee Khee <vee.khee.wong@linux.intel.com>
Signed-off-by: default avatarTan Tee Min <tee.min.tan@linux.intel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a9384a4c

drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c

+1 −0
Original line number Diff line number Diff line
@@ -454,6 +454,7 @@ static int intel_mgbe_common_data(struct pci_dev *pdev, 
	plat->has_gmac4 = 1;

	plat->force_sf_dma_mode = 0;

	plat->tso_en = 1;

	plat->sph_disable = 1;



	/* Multiplying factor to the clk_eee_i clock time

	 * period to make it closer to 100 ns. This value

drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

+1 −1
Original line number Diff line number Diff line
@@ -7021,7 +7021,7 @@ int stmmac_dvr_probe(struct device *device, 
		dev_info(priv->device, "TSO feature enabled\n");

	}



	if (priv->dma_cap.sphen) {

	if (priv->dma_cap.sphen && !priv->plat->sph_disable) {

		ndev->hw_features |= NETIF_F_GRO;

		priv->sph_cap = true;

		priv->sph = priv->sph_cap;

include/linux/stmmac.h

+1 −0
Original line number Diff line number Diff line
@@ -270,5 +270,6 @@ struct plat_stmmacenet_data { 
	int msi_rx_base_vec;

	int msi_tx_base_vec;

	bool use_phy_wol;

	bool sph_disable;

};

#endif