Commit 47f10854 authored by Laurent Pinchart's avatar Laurent Pinchart
Browse files

drm: Don't export the drm_gem_dumb_destroy() function 



The drm_gem_dumb_destroy() isn't used in drivers, don't export it.

Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 913848ad

drivers/gpu/drm/drm_dumb_buffers.c

+5 −3
Original line number Diff line number Diff line
@@ -29,6 +29,7 @@ 
#include <drm/drm_mode.h>



#include "drm_crtc_internal.h"

#include "drm_internal.h"



/**

 * DOC: overview
@@ -46,9 +47,10 @@ 
 * KMS frame buffers.

 *

 * To support dumb objects drivers must implement the &drm_driver.dumb_create

 * operation. &drm_driver.dumb_destroy defaults to drm_gem_dumb_destroy() if

 * not set and &drm_driver.dumb_map_offset defaults to

 * drm_gem_dumb_map_offset(). See the callbacks for further details.

 * and &drm_driver.dumb_map_offset operations (the latter defaults to

 * drm_gem_dumb_map_offset() if not set). Drivers that don't use GEM handles

 * additionally need to implement the &drm_driver.dumb_destroy operation. See

 * the callbacks for further details.

 *

 * Note that dumb objects may not be used for gpu acceleration, as has been

 * attempted on some ARM embedded platforms. Such drivers really must have

drivers/gpu/drm/drm_gem.c

+1 −11
Original line number Diff line number Diff line
@@ -335,22 +335,12 @@ int drm_gem_dumb_map_offset(struct drm_file *file, struct drm_device *dev, 
}

EXPORT_SYMBOL_GPL(drm_gem_dumb_map_offset);



/**

 * drm_gem_dumb_destroy - dumb fb callback helper for gem based drivers

 * @file: drm file-private structure to remove the dumb handle from

 * @dev: corresponding drm_device

 * @handle: the dumb handle to remove

 *

 * This implements the &drm_driver.dumb_destroy kms driver callback for drivers

 * which use gem to manage their backing storage.

 */

int drm_gem_dumb_destroy(struct drm_file *file,

			 struct drm_device *dev,

			 uint32_t handle)

			 u32 handle)

{

	return drm_gem_handle_delete(file, handle);

}

EXPORT_SYMBOL(drm_gem_dumb_destroy);



/**

 * drm_gem_handle_create_tail - internal functions to create a handle

drivers/gpu/drm/drm_internal.h

+3 −0
Original line number Diff line number Diff line
@@ -191,6 +191,9 @@ void drm_gem_unpin(struct drm_gem_object *obj); 
int drm_gem_vmap(struct drm_gem_object *obj, struct dma_buf_map *map);

void drm_gem_vunmap(struct drm_gem_object *obj, struct dma_buf_map *map);



int drm_gem_dumb_destroy(struct drm_file *file, struct drm_device *dev,

			 u32 handle);



/* drm_debugfs.c drm_debugfs_crc.c */

#if defined(CONFIG_DEBUG_FS)

int drm_debugfs_init(struct drm_minor *minor, int minor_id,

include/drm/drm_gem.h

+0 −3
Original line number Diff line number Diff line
@@ -416,8 +416,5 @@ int drm_gem_fence_array_add_implicit(struct xarray *fence_array, 
				     bool write);

int drm_gem_dumb_map_offset(struct drm_file *file, struct drm_device *dev,

			    u32 handle, u64 *offset);

int drm_gem_dumb_destroy(struct drm_file *file,

			 struct drm_device *dev,

			 uint32_t handle);



#endif /* __DRM_GEM_H__ */