Commit 47e6ab24 authored by Kuniyuki Iwashima's avatar Kuniyuki Iwashima Committed by David S. Miller
Browse files

tcp: Fix a data-race around sysctl_tcp_max_orphans. 



While reading sysctl_tcp_max_orphans, it can be changed concurrently.
So, we need to add READ_ONCE() to avoid a data-race.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Signed-off-by: default avatarKuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e8778208

net/ipv4/tcp.c

+2 −1
Original line number Diff line number Diff line
@@ -2715,7 +2715,8 @@ static void tcp_orphan_update(struct timer_list *unused) 


static bool tcp_too_many_orphans(int shift)

{

	return READ_ONCE(tcp_orphan_cache) << shift > sysctl_tcp_max_orphans;

	return READ_ONCE(tcp_orphan_cache) << shift >

		READ_ONCE(sysctl_tcp_max_orphans);

}



bool tcp_check_oom(struct sock *sk, int shift)