Commit 47e4bb14 authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

net: sit: unregister_netdevice on newlink's error path 



We need to unregister the netdevice if config failed.
.ndo_uninit takes care of most of the heavy lifting.

This was uncovered by recent commit c269a24c ("net: make
free_netdev() more lenient with unregistering devices").
Previously the partially-initialized device would be left
in the system.

Reported-and-tested-by: default avatar <syzbot+2393580080a2da190f04@syzkaller.appspotmail.com>
Fixes: e2f1f072 ("sit: allow to configure 6rd tunnels via netlink")
Acked-by: default avatarNicolas Dichtel <nicolas.dichtel@6wind.com>
Link: https://lore.kernel.org/r/20210114012947.2515313-1-kuba@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 5b55299e

net/ipv6/sit.c

+4 −1
Original line number Diff line number Diff line
@@ -1645,8 +1645,11 @@ static int ipip6_newlink(struct net *src_net, struct net_device *dev, 
	}



#ifdef CONFIG_IPV6_SIT_6RD

	if (ipip6_netlink_6rd_parms(data, &ip6rd))

	if (ipip6_netlink_6rd_parms(data, &ip6rd)) {

		err = ipip6_tunnel_update_6rd(nt, &ip6rd);

		if (err < 0)

			unregister_netdevice_queue(dev, NULL);

	}

#endif



	return err;