Commit 47c5d829 authored by Johan Hovold's avatar Johan Hovold Committed by Luiz Augusto von Dentz
Browse files

Bluetooth: hci_qca: fix debugfs registration 



Since commit 3e4be65e ("Bluetooth: hci_qca: Add poweroff support
during hci down for wcn3990"), the setup callback which registers the
debugfs interface can be called multiple times.

This specifically leads to the following error when powering on the
controller:

	debugfs: Directory 'ibs' with parent 'hci0' already present!

Add a driver flag to avoid trying to register the debugfs interface more
than once.

Fixes: 3e4be65e ("Bluetooth: hci_qca: Add poweroff support during hci down for wcn3990")
Cc: stable@vger.kernel.org	# 4.20
Signed-off-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Signed-off-by: default avatarLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
parent fe2ccc6c

drivers/bluetooth/hci_qca.c

+5 −1
Original line number Diff line number Diff line
@@ -78,7 +78,8 @@ enum qca_flags { 
	QCA_HW_ERROR_EVENT,

	QCA_SSR_TRIGGERED,

	QCA_BT_OFF,

	QCA_ROM_FW

	QCA_ROM_FW,

	QCA_DEBUGFS_CREATED,

};



enum qca_capabilities {
@@ -635,6 +636,9 @@ static void qca_debugfs_init(struct hci_dev *hdev) 
	if (!hdev->debugfs)

		return;



	if (test_and_set_bit(QCA_DEBUGFS_CREATED, &qca->flags))

		return;



	ibs_dir = debugfs_create_dir("ibs", hdev->debugfs);



	/* read only */