Commit 47c45c39 authored by Felix Kuehling's avatar Felix Kuehling Committed by Alex Deucher
Browse files

drm/amdkfd: Use a new capability bit for SRAM ECC 



Existing, buggy user mode breaks when SRAM ECC is correctly reported as
"enabled". To avoid breaking existing user mode, deprecate that bit and
leave it as 0. Define a new bit to report the actual SRAM ECC mode that
new, correct user mode can use in the future.

Fixes: 7ec177bdcfc1 ("drm/amdkfd: fix set kfd node ras properties value")
Signed-off-by: default avatarFelix Kuehling <Felix.Kuehling@amd.com>
Reviewed-by: default avatarKent Russell <kent.russell@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent a00aacdf

drivers/gpu/drm/amd/amdkfd/kfd_topology.h

+3 −2
Original line number Diff line number Diff line
@@ -47,13 +47,14 @@ 
#define HSA_CAP_DOORBELL_TYPE_2_0		0x2

#define HSA_CAP_AQL_QUEUE_DOUBLE_MAP		0x00004000



#define HSA_CAP_SRAM_EDCSUPPORTED		0x00080000

#define HSA_CAP_RESERVED_WAS_SRAM_EDCSUPPORTED	0x00080000 /* Old buggy user mode depends on this being 0 */

#define HSA_CAP_MEM_EDCSUPPORTED		0x00100000

#define HSA_CAP_RASEVENTNOTIFY			0x00200000

#define HSA_CAP_ASIC_REVISION_MASK		0x03c00000

#define HSA_CAP_ASIC_REVISION_SHIFT		22

#define HSA_CAP_SRAM_EDCSUPPORTED		0x04000000



#define HSA_CAP_RESERVED			0xfc078000

#define HSA_CAP_RESERVED			0xf80f8000



struct kfd_node_properties {

	uint64_t hive_id;