Unverified Commit 47c3e06e authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Mark Brown
Browse files

spi: tegra210-quad: Fix missin IRQ check in tegra_qspi_probe 



This func misses checking for platform_get_irq()'s call and may passes the
negative error codes to request_threaded_irq(), which takes unsigned IRQ #,
causing it to fail with -EINVAL, overriding an original error code.
Stop calling request_threaded_irq() with invalid IRQ #s.

Fixes: 921fc183 ("spi: tegra210-quad: Add support for Tegra210 QSPI controller")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220128165956.27821-1-linmq006@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 3b8ab4da

drivers/spi/spi-tegra210-quad.c

+2 −0
Original line number Diff line number Diff line
@@ -1240,6 +1240,8 @@ static int tegra_qspi_probe(struct platform_device *pdev) 


	tqspi->phys = r->start;

	qspi_irq = platform_get_irq(pdev, 0);

	if (qspi_irq < 0)

		return qspi_irq;

	tqspi->irq = qspi_irq;



	tqspi->clk = devm_clk_get(&pdev->dev, "qspi");