Unverified Commit 47c32b2b authored by Patrice Chotard's avatar Patrice Chotard Committed by Mark Brown
Browse files

spi: stm32-qspi: Fix pm_runtime management in stm32_qspi_transfer_one_message() 



ctrl->auto_runtime_pm was wrongly set to true when adding
transfer_one_message() callback.
As explained in commit 6e6ccb3d4cdc ("spi: stm32-qspi: Add pm_runtime support")
the expected behavior is to prevent runtime suspends between each transfer.

Add needed pm_runtime API calls in stm32_qspi_transfer_one_message().

Fixes: a557fca6 ("spi: stm32_qspi: Add transfer_one_message() spi callback")
Signed-off-by: default avatarPatrice Chotard <patrice.chotard@foss.st.com>
Link: https://lore.kernel.org/r/20220829123250.2170562-1-patrice.chotard@foss.st.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 56ec4562

drivers/spi/spi-stm32-qspi.c

+7 −1
Original line number Diff line number Diff line
@@ -567,6 +567,10 @@ static int stm32_qspi_transfer_one_message(struct spi_controller *ctrl, 
	if (!spi->cs_gpiod)

		return -EOPNOTSUPP;



	ret = pm_runtime_resume_and_get(qspi->dev);

	if (ret < 0)

		return ret;



	mutex_lock(&qspi->lock);



	gpiod_set_value_cansleep(spi->cs_gpiod, true);
@@ -629,6 +633,9 @@ static int stm32_qspi_transfer_one_message(struct spi_controller *ctrl, 
	msg->status = ret;

	spi_finalize_current_message(ctrl);



	pm_runtime_mark_last_busy(qspi->dev);

	pm_runtime_put_autosuspend(qspi->dev);



	return ret;

}
@@ -847,7 +854,6 @@ static int stm32_qspi_probe(struct platform_device *pdev) 
	ctrl->mem_ops = &stm32_qspi_mem_ops;

	ctrl->use_gpio_descriptors = true;

	ctrl->transfer_one_message = stm32_qspi_transfer_one_message;

	ctrl->auto_runtime_pm = true;

	ctrl->num_chipselect = STM32_QSPI_MAX_NORCHIP;

	ctrl->dev.of_node = dev->of_node;