Commit 47b5d2a1 authored by Roi Dayan's avatar Roi Dayan Committed by Jakub Kicinski
Browse files

net/sched: act_ct: Fix adding udp port mangle operation 



Need to use the udp header type and not tcp.

Fixes: 9c26ba9b ("net/sched: act_ct: Instantiate flow table entry actions")
Signed-off-by: default avatarRoi Dayan <roid@nvidia.com>
Reviewed-by: default avatarPaul Blakey <paulb@nvidia.com>
Link: https://lore.kernel.org/r/20201019090244.3015186-1-roid@nvidia.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent acd7aaf5

net/sched/act_ct.c

+2 −2
Original line number Diff line number Diff line
@@ -156,11 +156,11 @@ tcf_ct_flow_table_add_action_nat_udp(const struct nf_conntrack_tuple *tuple, 
	__be16 target_dst = target.dst.u.udp.port;



	if (target_src != tuple->src.u.udp.port)

		tcf_ct_add_mangle_action(action, FLOW_ACT_MANGLE_HDR_TYPE_TCP,

		tcf_ct_add_mangle_action(action, FLOW_ACT_MANGLE_HDR_TYPE_UDP,

					 offsetof(struct udphdr, source),

					 0xFFFF, be16_to_cpu(target_src));

	if (target_dst != tuple->dst.u.udp.port)

		tcf_ct_add_mangle_action(action, FLOW_ACT_MANGLE_HDR_TYPE_TCP,

		tcf_ct_add_mangle_action(action, FLOW_ACT_MANGLE_HDR_TYPE_UDP,

					 offsetof(struct udphdr, dest),

					 0xFFFF, be16_to_cpu(target_dst));

}