Commit 4785aa80 authored by Oza Pawandeep's avatar Oza Pawandeep Committed by Will Deacon
Browse files

cpuidle, ACPI: Evaluate LPI arch_flags for broadcast timer 



Arm® Functional Fixed Hardware Specification defines LPI states,
which provide an architectural context loss flags field that can
be used to describe the context that might be lost when an LPI
state is entered.

- Core context Lost
        - General purpose registers.
        - Floating point and SIMD registers.
        - System registers, include the System register based
        - generic timer for the core.
        - Debug register in the core power domain.
        - PMU registers in the core power domain.
        - Trace register in the core power domain.
- Trace context loss
- GICR
- GICD

Qualcomm's custom CPUs preserves the architectural state,
including keeping the power domain for local timers active.
when core is power gated, the local timers are sufficient to
wake the core up without needing broadcast timer.

The patch fixes the evaluation of cpuidle arch_flags, and moves only to
broadcast timer if core context lost is defined in ACPI LPI.

Fixes: a36a7fec ("ACPI / processor_idle: Add support for Low Power Idle(LPI) states")
Reviewed-by: default avatarSudeep Holla <sudeep.holla@arm.com>
Acked-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: default avatarOza Pawandeep <quic_poza@quicinc.com>
Link: https://lore.kernel.org/r/20231003173333.2865323-1-quic_poza@quicinc.com


Signed-off-by: default avatarWill Deacon <will@kernel.org>
parent 471470bc

arch/arm64/include/asm/acpi.h

+19 −0
Original line number Diff line number Diff line
@@ -9,6 +9,7 @@ 
#ifndef _ASM_ACPI_H

#define _ASM_ACPI_H



#include <linux/cpuidle.h>

#include <linux/efi.h>

#include <linux/memblock.h>

#include <linux/psci.h>
@@ -44,6 +45,24 @@ 


#define ACPI_MADT_GICC_TRBE  (offsetof(struct acpi_madt_generic_interrupt, \

	trbe_interrupt) + sizeof(u16))

/*

 * Arm® Functional Fixed Hardware Specification Version 1.2.

 * Table 2: Arm Architecture context loss flags

 */

#define CPUIDLE_CORE_CTXT		BIT(0) /* Core context Lost */



static inline unsigned int arch_get_idle_state_flags(u32 arch_flags)

{

	if (arch_flags & CPUIDLE_CORE_CTXT)

		return CPUIDLE_FLAG_TIMER_STOP;



	return 0;

}

#define arch_get_idle_state_flags arch_get_idle_state_flags



#define CPUIDLE_TRACE_CTXT		BIT(1) /* Trace context loss */

#define CPUIDLE_GICR_CTXT		BIT(2) /* GICR */

#define CPUIDLE_GICD_CTXT		BIT(3) /* GICD */



/* Basic configuration for ACPI */

#ifdef	CONFIG_ACPI

drivers/acpi/processor_idle.c

+1 −2
Original line number Diff line number Diff line
@@ -1217,8 +1217,7 @@ static int acpi_processor_setup_lpi_states(struct acpi_processor *pr) 
		strscpy(state->desc, lpi->desc, CPUIDLE_DESC_LEN);

		state->exit_latency = lpi->wake_latency;

		state->target_residency = lpi->min_residency;

		if (lpi->arch_flags)

			state->flags |= CPUIDLE_FLAG_TIMER_STOP;

		state->flags |= arch_get_idle_state_flags(lpi->arch_flags);

		if (i != 0 && lpi->entry_method == ACPI_CSTATE_FFH)

			state->flags |= CPUIDLE_FLAG_RCU_IDLE;

		state->enter = acpi_idle_lpi_enter;

include/linux/acpi.h

+9 −0
Original line number Diff line number Diff line
@@ -1480,6 +1480,15 @@ static inline int lpit_read_residency_count_address(u64 *address) 
}

#endif



#ifdef CONFIG_ACPI_PROCESSOR_IDLE

#ifndef arch_get_idle_state_flags

static inline unsigned int arch_get_idle_state_flags(u32 arch_flags)

{

	return 0;

}

#endif

#endif /* CONFIG_ACPI_PROCESSOR_IDLE */



#ifdef CONFIG_ACPI_PPTT

int acpi_pptt_cpu_is_thread(unsigned int cpu);

int find_acpi_cpu_topology(unsigned int cpu, int level);