Commit 4782c5d8 authored by Dan Carpenter's avatar Dan Carpenter Committed by Saeed Mahameed
Browse files

net/mlx5: Fix a NULL vs IS_ERR() check 



The mlx5_chains_get_table() function doesn't return NULL, it returns
error pointers so we need to fix this condition.

Fixes: 34ca6535 ("net/mlx5: E-Switch, Indirect table infrastructure")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarVlad Buslov <vladbu@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 2dd4571b

drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c

+1 −1
Original line number Diff line number Diff line
@@ -216,7 +216,7 @@ static int mlx5_esw_indir_table_rule_get(struct mlx5_eswitch *esw, 
	flow_act.flags = FLOW_ACT_IGNORE_FLOW_LEVEL | FLOW_ACT_NO_APPEND;

	dest.type = MLX5_FLOW_DESTINATION_TYPE_FLOW_TABLE;

	dest.ft = mlx5_chains_get_table(chains, 0, 1, 0);

	if (!dest.ft) {

	if (IS_ERR(dest.ft)) {

		err = PTR_ERR(dest.ft);

		goto err_table;

	}