Commit 474d0997 authored by Paul E. McKenney's avatar Paul E. McKenney
Browse files

tasks-rcu: Make show_rcu_tasks_gp_kthreads() be static inline 



In some architectures, the no-op variant of show_rcu_tasks_gp_kthreads()
get "no previous prototype" compiler warnings.  These are false positives
given that kernel/rcu/tasks.h is included only once.  But why put up
with the compiler noise?

This commit therefore adds "static inline" to this definition to force
the compiler to accept this situation, while also moving it to its proper
place in kernel/rcu/rcu.h.

Reported-by: default avatarkernel test robot <lkp@intel.com>
[ paulmck: Update per Stephen Rothwell feedback. ]
Signed-off-by: default avatarPaul E. McKenney <paulmck@kernel.org>
parent cf868c2a

kernel/rcu/rcu.h

+4 −0
Original line number Diff line number Diff line
@@ -441,7 +441,11 @@ bool rcu_gp_is_expedited(void); /* Internal RCU use. */ 
void rcu_expedite_gp(void);

void rcu_unexpedite_gp(void);

void rcupdate_announce_bootup_oddness(void);

#ifdef CONFIG_TASKS_RCU_GENERIC

void show_rcu_tasks_gp_kthreads(void);

#else /* #ifdef CONFIG_TASKS_RCU_GENERIC */

static inline void show_rcu_tasks_gp_kthreads(void) {}

#endif /* #else #ifdef CONFIG_TASKS_RCU_GENERIC */

void rcu_request_urgent_qs_task(struct task_struct *t);

#endif /* #else #ifdef CONFIG_TINY_RCU */

kernel/rcu/tasks.h

+0 −1
Original line number Diff line number Diff line
@@ -1401,5 +1401,4 @@ void __init rcu_init_tasks_generic(void) 


#else /* #ifdef CONFIG_TASKS_RCU_GENERIC */

static inline void rcu_tasks_bootup_oddness(void) {}

void show_rcu_tasks_gp_kthreads(void) {}

#endif /* #else #ifdef CONFIG_TASKS_RCU_GENERIC */