Commit 47446b50 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

firmware_loader: fix up to_fw_sysfs() to preserve const



to_fw_sysfs() was changed in commit 23680f0b ("driver core: make
struct class.dev_uevent() take a const *") to pass in a const pointer
but not pass it back out to handle some changes in the driver core.
That isn't the best idea as it could cause problems if used incorrectly,
so switch to use the container_of_const() macro instead which will
preserve the const status of the pointer and enforce it by the compiler.

Fixes: 23680f0b ("driver core: make struct class.dev_uevent() take a const *")
Cc: Luis Chamberlain <mcgrof@kernel.org>
Reviewed-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Acked-by: default avatarRuss Weight <russell.h.weight@intel.com>
Acked-by: default avatarRafael J. Wysocki <rafael@kernel.org>
Link: https://lore.kernel.org/r/20221205121206.166576-4-gregkh@linuxfoundation.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c3da6792
Loading
Loading
Loading
Loading
+1 −5
Original line number Diff line number Diff line
@@ -80,11 +80,7 @@ struct fw_sysfs {
	struct firmware *fw;
	void *fw_upload_priv;
};

static inline struct fw_sysfs *to_fw_sysfs(const struct device *dev)
{
	return container_of(dev, struct fw_sysfs, dev);
}
#define to_fw_sysfs(__dev)	container_of_const(__dev, struct fw_sysfs, dev)

void __fw_load_abort(struct fw_priv *fw_priv);