Commit 470ec4ed authored by Jens Axboe's avatar Jens Axboe
Browse files

io-wq: fix double put of 'wq' in error path 



We are already freeing the wq struct in both spots, so don't put it and
get it freed twice.

Reported-by: default avatar <syzbot+7bf785eedca35ca05501@syzkaller.appspotmail.com>
Fixes: 4fb6ac32 ("io-wq: improve manager/worker handling over exec")
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent d364d9e5

fs/io-wq.c

+0 −2
Original line number Diff line number Diff line
@@ -826,7 +826,6 @@ static int io_wq_fork_manager(struct io_wq *wq) 
		return 0;

	}



	io_wq_put(wq);

	return ret;

}
@@ -1078,7 +1077,6 @@ struct io_wq *io_wq_create(unsigned bounded, struct io_wq_data *data) 
	if (!ret)

		return wq;



	io_wq_put(wq);

	io_wq_put_hash(data->hash);

err:

	cpuhp_state_remove_instance_nocalls(io_wq_online, &wq->cpuhp_node);