Commit 46fb6512 authored by Zhang Changzhong's avatar Zhang Changzhong Committed by David S. Miller
Browse files

net: ethernet: ti: am65-cpsw: fix error handling in am65_cpsw_nuss_probe() 



The am65_cpsw_nuss_cleanup_ndev() function calls unregister_netdev()
even if register_netdev() fails, which triggers WARN_ON(1) in
unregister_netdevice_many(). To fix it, make sure that
unregister_netdev() is called only on registered netdev.

Compile tested only.

Fixes: 84b4aa49 ("net: ethernet: ti: am65-cpsw: add multi port support in mac-only mode")
Signed-off-by: default avatarZhang Changzhong <zhangchangzhong@huawei.com>
Reviewed-by: default avatarMaciej Fijalkowski <maciej.fijalkowski@intel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 763465e6

drivers/net/ethernet/ti/am65-cpsw-nuss.c

+1 −1
Original line number Diff line number Diff line
@@ -2082,7 +2082,7 @@ static void am65_cpsw_nuss_cleanup_ndev(struct am65_cpsw_common *common) 


	for (i = 0; i < common->port_num; i++) {

		port = &common->ports[i];

		if (port->ndev)

		if (port->ndev && port->ndev->reg_state == NETREG_REGISTERED)

			unregister_netdev(port->ndev);

	}

}