Commit 46f748cc authored by Alex Elder's avatar Alex Elder Committed by Jakub Kicinski
Browse files

net: ipa: explicitly disallow inter-EE interrupts 



It is possible for other execution environments (EEs, like the modem)
to request changes to local (AP) channel or event ring state.  We do
not support this feature.

In gsi_irq_setup(), explicitly zero the mask that defines which
channels are permitted to generate inter-EE channel state change
interrupts.  Do the same for the event ring mask.

Signed-off-by: default avatarAlex Elder <elder@linaro.org>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 06c86328

drivers/net/ipa/gsi.c

+2 −2
Original line number Diff line number Diff line
@@ -259,6 +259,8 @@ static void gsi_irq_setup(struct gsi *gsi) 
	iowrite32(0, gsi->virt + GSI_CNTXT_SRC_EV_CH_IRQ_MSK_OFFSET);

	iowrite32(0, gsi->virt + GSI_CNTXT_GLOB_IRQ_EN_OFFSET);

	iowrite32(0, gsi->virt + GSI_CNTXT_SRC_IEOB_IRQ_MSK_OFFSET);

	iowrite32(0, gsi->virt + GSI_INTER_EE_SRC_CH_IRQ_OFFSET);

	iowrite32(0, gsi->virt + GSI_INTER_EE_SRC_EV_CH_IRQ_OFFSET);

}



/* Turn off all GSI interrupts when we're all done */
@@ -307,8 +309,6 @@ static void gsi_irq_enable(struct gsi *gsi) 
	iowrite32(ERROR_INT_FMASK, gsi->virt + GSI_CNTXT_GLOB_IRQ_EN_OFFSET);

	gsi->type_enabled_bitmap |= BIT(GSI_GLOB_EE);



	/* We don't use inter-EE channel or event interrupts */



	/* Never enable GSI_BREAK_POINT */

	val = GSI_CNTXT_GSI_IRQ_ALL & ~BREAK_POINT_FMASK;

	iowrite32(val, gsi->virt + GSI_CNTXT_GSI_IRQ_EN_OFFSET);