Commit 46ef6090 authored by Pali Rohár's avatar Pali Rohár Committed by Lorenzo Pieralisi
Browse files

PCI: aardvark: Fix configuring Reference clock 

Commit 36669701 ("PCI: aardvark: Add PHY support") introduced
configuration of PCIe Reference clock via PCIE_CORE_REF_CLK_REG register,
but did it incorrectly.

PCIe Reference clock differential pair is routed from system board to
endpoint card, so on CPU side it has output direction. Therefore it is
required to enable transmitting and disable receiving.

Default configuration according to Armada 3700 Functional Specifications is
enabled receiver part and disabled transmitter.

We need this change because otherwise PCIe Reference clock is configured to
some undefined state when differential pair is used for both transmitting
and receiving.

Fix this by disabling receiver part.

Link: https://lore.kernel.org/r/20211005180952.6812-6-kabel@kernel.org


Fixes: 36669701 ("PCI: aardvark: Add PHY support")
Signed-off-by: default avatarPali Rohár <pali@kernel.org>
Signed-off-by: default avatarMarek Behún <kabel@kernel.org>
Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: default avatarMarek Behún <kabel@kernel.org>
Cc: stable@vger.kernel.org
parent d419052b

drivers/pci/controller/pci-aardvark.c

+8 −1
Original line number Diff line number Diff line
@@ -99,6 +99,7 @@ 
#define     PCIE_CORE_CTRL2_MSI_ENABLE		BIT(10)

#define PCIE_CORE_REF_CLK_REG			(CONTROL_BASE_ADDR + 0x14)

#define     PCIE_CORE_REF_CLK_TX_ENABLE		BIT(1)

#define     PCIE_CORE_REF_CLK_RX_ENABLE		BIT(2)

#define PCIE_MSG_LOG_REG			(CONTROL_BASE_ADDR + 0x30)

#define PCIE_ISR0_REG				(CONTROL_BASE_ADDR + 0x40)

#define PCIE_MSG_PM_PME_MASK			BIT(7)
@@ -451,9 +452,15 @@ static void advk_pcie_setup_hw(struct advk_pcie *pcie) 
	u32 reg;

	int i;



	/* Enable TX */

	/*

	 * Configure PCIe Reference clock. Direction is from the PCIe

	 * controller to the endpoint card, so enable transmitting of

	 * Reference clock differential signal off-chip and disable

	 * receiving off-chip differential signal.

	 */

	reg = advk_readl(pcie, PCIE_CORE_REF_CLK_REG);

	reg |= PCIE_CORE_REF_CLK_TX_ENABLE;

	reg &= ~PCIE_CORE_REF_CLK_RX_ENABLE;

	advk_writel(pcie, reg, PCIE_CORE_REF_CLK_REG);



	/* Set to Direct mode */