Commit 46ee7350 authored by Guojia Liao's avatar Guojia Liao Committed by David S. Miller
Browse files

net: hns3: add or modify comments 



To explain some code, this patch adds some comments, and modifies or
merges some comments to make them more neat.

Signed-off-by: default avatarGuojia Liao <liaoguojia@huawei.com>
Signed-off-by: default avatarZhongzhu Liu <liuzhongzhu@huawei.com>
Signed-off-by: default avatarWeihang Li <liweihang@hisilicon.com>
Signed-off-by: default avatarGuangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d83d508b

drivers/net/ethernet/hisilicon/hns3/hns3_enet.c

+4 −4
Original line number Diff line number Diff line
@@ -229,9 +229,9 @@ static void hns3_vector_gl_rl_init(struct hns3_enet_tqp_vector *tqp_vector, 
	/* initialize the configuration for interrupt coalescing.

	 * 1. GL (Interrupt Gap Limiter)

	 * 2. RL (Interrupt Rate Limiter)

	 *

	 * Default: enable interrupt coalescing self-adaptive and GL

	 */



	/* Default: enable interrupt coalescing self-adaptive and GL */

	tqp_vector->tx_group.coal.gl_adapt_enable = 1;

	tqp_vector->rx_group.coal.gl_adapt_enable = 1;
@@ -4207,8 +4207,8 @@ int hns3_nic_reset_all_ring(struct hnae3_handle *h) 
static void hns3_store_coal(struct hns3_nic_priv *priv)

{

	/* ethtool only support setting and querying one coal

	 * configuation for now, so save the vector 0' coal

	 * configuation here in order to restore it.

	 * configuration for now, so save the vector 0' coal

	 * configuration here in order to restore it.

	 */

	memcpy(&priv->tx_coal, &priv->tqp_vector[0].tx_group.coal,

	       sizeof(struct hns3_enet_coalesce));

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c

+3 −0
Original line number Diff line number Diff line
@@ -897,14 +897,17 @@ static void hclge_dbg_fd_tcam_read(struct hclge_dev *hdev, u8 stage, 
	dev_info(&hdev->pdev->dev, " read result tcam key %s(%u):\n",

		 sel_x ? "x" : "y", loc);



	/* tcam_data0 ~ tcam_data1 */

	req = (u32 *)req1->tcam_data;

	for (i = 0; i < 2; i++)

		dev_info(&hdev->pdev->dev, "%08x\n", *req++);



	/* tcam_data2 ~ tcam_data7 */

	req = (u32 *)req2->tcam_data;

	for (i = 0; i < 6; i++)

		dev_info(&hdev->pdev->dev, "%08x\n", *req++);



	/* tcam_data8 ~ tcam_data12 */

	req = (u32 *)req3->tcam_data;

	for (i = 0; i < 5; i++)

		dev_info(&hdev->pdev->dev, "%08x\n", *req++);

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

+4 −4
Original line number Diff line number Diff line
@@ -2810,9 +2810,9 @@ static u32 hclge_check_event_cause(struct hclge_dev *hdev, u32 *clearval) 
	 * defer the processing of the mailbox events. Since, we would have not

	 * cleared RX CMDQ event this time we would receive again another

	 * interrupt from H/W just for the mailbox.

	 *

	 * check for vector0 reset event sources

	 */



	/* check for vector0 reset event sources */

	if (BIT(HCLGE_VECTOR0_IMPRESET_INT_B) & rst_src_reg) {

		dev_info(&hdev->pdev->dev, "IMP reset interrupt\n");

		set_bit(HNAE3_IMP_RESET, &hdev->reset_pending);
@@ -8000,7 +8000,7 @@ int hclge_set_vlan_filter(struct hnae3_handle *handle, __be16 proto, 
		return -EBUSY;

	}



	/* When port base vlan enabled, we use port base vlan as the vlan

	/* when port base vlan enabled, we use port base vlan as the vlan

	 * filter entry. In this case, we don't update vlan filter table

	 * when user add new vlan or remove exist vlan, just update the vport

	 * vlan list. The vlan id in vlan list will be writen in vlan filter
@@ -8019,7 +8019,7 @@ int hclge_set_vlan_filter(struct hnae3_handle *handle, __be16 proto, 
			hclge_add_vport_vlan_table(vport, vlan_id,

						   writen_to_tbl);

	} else if (is_kill) {

		/* When remove hw vlan filter failed, record the vlan id,

		/* when remove hw vlan filter failed, record the vlan id,

		 * and try to remove it from hw later, to be consistence

		 * with stack

		 */

drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c

+4 −5
Original line number Diff line number Diff line
@@ -1269,7 +1269,7 @@ static int hclgevf_set_vlan_filter(struct hnae3_handle *handle, 
				   HCLGE_MBX_VLAN_FILTER, msg_data,

				   HCLGEVF_VLAN_MBX_MSG_LEN, false, NULL, 0);



	/* When remove hw vlan filter failed, record the vlan id,

	/* when remove hw vlan filter failed, record the vlan id,

	 * and try to remove it from hw later, to be consistence

	 * with stack.

	 */
@@ -1784,9 +1784,8 @@ static void hclgevf_reset_service_task(struct work_struct *work) 
		 * 1b and 2. cases but we will not get any intimation about 1a

		 * from PF as cmdq would be in unreliable state i.e. mailbox

		 * communication between PF and VF would be broken.

		 */



		/* if we are never geting into pending state it means either:

		 *

		 * if we are never geting into pending state it means either:

		 * 1. PF is not receiving our request which could be due to IMP

		 *    reset

		 * 2. PF is screwed

drivers/net/ethernet/hisilicon/hns3/hnae3.h

+6 −6

File changed.

Contains only whitespace changes.

drivers/net/ethernet/hisilicon/hns3/hns3_enet.h

+4 −4

File changed.

Contains only whitespace changes.

drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c

+1 −1

File changed.

Contains only whitespace changes.

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c

+1 −1

File changed.

Contains only whitespace changes.