Commit 46dcd1cc authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Jiri Kosina
Browse files

HID: logitech-hidpp: Use 'atomic_inc_return' instead of hand-writing it 



This function logs a warning if the workqueue gets too big.
In order to save a few cycles, use 'atomic_inc_return()' instead of an
'atomic_inc()/atomic_read()' sequence.

This axes a line of code and saves a 'atomic_read()' call.

Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent df04fbe8

drivers/hid/hid-logitech-hidpp.c

+1 −2
Original line number Diff line number Diff line
@@ -2240,11 +2240,10 @@ static int hidpp_ff_queue_work(struct hidpp_ff_private_data *data, int effect_id 
	wd->size = size;

	memcpy(wd->params, params, size);



	atomic_inc(&data->workqueue_size);

	s = atomic_inc_return(&data->workqueue_size);

	queue_work(data->wq, &wd->work);



	/* warn about excessive queue size */

	s = atomic_read(&data->workqueue_size);

	if (s >= 20 && s % 20 == 0)

		hid_warn(data->hidpp->hid_dev, "Force feedback command queue contains %d commands, causing substantial delays!", s);