Commit 46dc9674 authored Mar 30, 2022 by Christoph Hellwig Committed by Jens Axboe Apr 18, 2022

loop: don't freeze the queue in lo_release



By the time the final ->release is called there can't be outstanding I/O.
For non-final ->release there is no need for driver action at all.

Thus remove the useless queue freeze.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Jan Kara <jack@suse.cz>
Tested-by: Darrick J. Wong <djwong@kernel.org>
Link: https://lore.kernel.org/r/20220330052917.2566582-10-hch@lst.de


Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 98ded54a

drivers/block/loop.c

+0 −7

Original line number	Diff line number	Diff line
		@@ -1749,13 +1749,6 @@ static void lo_release(struct gendisk *disk, fmode_t mode)
		*/
		__loop_clr_fd(lo, true);
		return;
		} else if (lo->lo_state == Lo_bound) {
		/*
		* Otherwise keep thread (if running) and config,
		* but flush possible ongoing bios in thread.
		*/
		blk_mq_freeze_queue(lo->lo_queue);
		blk_mq_unfreeze_queue(lo->lo_queue);
		}

		out_unlock: