Commit 46cf1954 authored by Yang Yingliang's avatar Yang Yingliang Committed by Takashi Iwai
Browse files

ALSA: arm: pxa: pxa2xx-ac97-lib: fix return value check of platform_get_irq() 



platform_get_irq() returns negative error number on failure, fix the
return value check in pxa2xx_ac97_hw_probe() and assign the error code
to 'ret'.

Fixes: 2548e6c7 ("ARM: pxa: pxa2xx-ac97-lib: use IRQ resource")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221029082001.3207380-1-yangyingliang@huawei.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 8d06679b

sound/arm/pxa2xx-ac97-lib.c

+3 −1
Original line number Diff line number Diff line
@@ -402,8 +402,10 @@ int pxa2xx_ac97_hw_probe(struct platform_device *dev) 
		goto err_clk2;



	irq = platform_get_irq(dev, 0);

	if (!irq)

	if (irq < 0) {

		ret = irq;

		goto err_irq;

	}



	ret = request_irq(irq, pxa2xx_ac97_irq, 0, "AC97", NULL);

	if (ret < 0)