Commit 46a53371 authored by Donghai Qiao's avatar Donghai Qiao Committed by Linus Torvalds
Browse files

mm/page_counter: remove an incorrect call to propagate_protected_usage() 

propagate_protected_usage() is called to propagate the usage change in
the page_counter structure.  But there is a call to this function from
page_counter_try_charge() when there is actually no usage change.  Hence
this call should be removed.

Link: https://lkml.kernel.org/r/20211118181125.3918222-1-dqiao@redhat.com


Signed-off-by: default avatarDonghai Qiao <dqiao@redhat.com>
Reviewed-by: default avatarRoman Gushchin <guro@fb.com>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 17c17367

mm/page_counter.c

+0 −1
Original line number Diff line number Diff line
@@ -120,7 +120,6 @@ bool page_counter_try_charge(struct page_counter *counter, 
		new = atomic_long_add_return(nr_pages, &c->usage);

		if (new > c->max) {

			atomic_long_sub(nr_pages, &c->usage);

			propagate_protected_usage(c, new);

			/*

			 * This is racy, but we can live with some

			 * inaccuracy in the failcnt which is only used