Commit 465d3b3a authored by Johan Hovold's avatar Johan Hovold
Browse files

USB: serial: xr: fix gpio-mode handling 



Fix the gpio-mode handling so that all the pins are under driver control
(i.e. in gpio mode) when hardware flow control is disabled.

This is specifically needed to be able to control RTS.

Fixes: c2d405aa ("USB: serial: add MaxLinear/Exar USB to Serial driver")
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
parent 736c0931

drivers/usb/serial/xr_serial.c

+3 −6
Original line number Diff line number Diff line
@@ -408,14 +408,11 @@ static void xr_set_flow_mode(struct tty_struct *tty, 
	if (ret)

		return;



	/* Set GPIO mode for controlling the pins manually by default. */

	gpio_mode &= ~XR21V141X_UART_MODE_GPIO_MASK;



	if (C_CRTSCTS(tty)) {

		dev_dbg(&port->dev, "Enabling hardware flow ctrl\n");



		/*

		 * RTS/CTS is the default flow control mode, so set GPIO mode

		 * for controlling the pins manually by default.

		 */

		gpio_mode &= ~XR21V141X_UART_MODE_GPIO_MASK;

		gpio_mode |= XR21V141X_UART_MODE_RTS_CTS;

		flow = XR21V141X_UART_FLOW_MODE_HW;

	} else if (I_IXON(tty)) {