Unverified Commit 4643e10a authored by Peter Ujfalusi's avatar Peter Ujfalusi Committed by Mark Brown
Browse files

ASoC: SOF: Intel: hda-loader: Clarify the cl_dsp_init() flow 



Update the comment for the cl_dsp_init() to clarify what is done by the
function and use the chip->init_core_mask instead of BIT(0) when
unstalling/running the init core.

Complements: 2a68ff84 ("ASoC: SOF: Intel: hda: Revisit IMR boot sequence")
Signed-off-by: default avatarPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Link: https://lore.kernel.org/r/20220609085949.29062-4-peter.ujfalusi@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent fcb3c775

sound/soc/sof/intel/hda-loader.c

+4 −4
Original line number Diff line number Diff line
@@ -95,9 +95,9 @@ struct hdac_ext_stream *hda_cl_stream_prepare(struct snd_sof_dev *sdev, unsigned 
}



/*

 * first boot sequence has some extra steps. core 0 waits for power

 * status on core 1, so power up core 1 also momentarily, keep it in

 * reset/stall and then turn it off

 * first boot sequence has some extra steps.

 * power on all host managed cores and only unstall/run the boot core to boot the

 * DSP then turn off all non boot cores (if any) is powered on.

 */

static int cl_dsp_init(struct snd_sof_dev *sdev, int stream_tag, bool imr_boot)

{
@@ -127,7 +127,7 @@ static int cl_dsp_init(struct snd_sof_dev *sdev, int stream_tag, bool imr_boot) 
	snd_sof_dsp_write(sdev, HDA_DSP_BAR, chip->ipc_req, ipc_hdr);



	/* step 3: unset core 0 reset state & unstall/run core 0 */

	ret = hda_dsp_core_run(sdev, BIT(0));

	ret = hda_dsp_core_run(sdev, chip->init_core_mask);

	if (ret < 0) {

		if (hda->boot_iteration == HDA_FW_BOOT_ATTEMPTS)

			dev_err(sdev->dev,