Commit 463c2149 authored by Toke Høiland-Jørgensen's avatar Toke Høiland-Jørgensen Committed by Alexei Starovoitov
Browse files

selftests/bpf: Add tests for target information in bpf_link info queries 



Extend the fexit_bpf2bpf test to check that the info for the bpf_link
returned by the kernel matches the expected values.

While we're updating the test, change existing uses of CHEC() to use the
much easier to read ASSERT_*() macros.

v2:
- Convert last CHECK() call and get rid of 'duration' var
- Split ASSERT_OK_PTR() checks to two separate if statements

Signed-off-by: default avatarToke Høiland-Jørgensen <toke@redhat.com>
Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
Acked-by: default avatarAndrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20210413091607.58945-2-toke@redhat.com
parent 441e8c66

tools/testing/selftests/bpf/prog_tests/fexit_bpf2bpf.c

+44 −14
Original line number Diff line number Diff line
@@ -58,42 +58,73 @@ static void test_fexit_bpf2bpf_common(const char *obj_file, 
				      test_cb cb)

{

	struct bpf_object *obj = NULL, *tgt_obj;

	__u32 retval, tgt_prog_id, info_len;

	struct bpf_prog_info prog_info = {};

	struct bpf_program **prog = NULL;

	struct bpf_link **link = NULL;

	__u32 duration = 0, retval;

	int err, tgt_fd, i;

	struct btf *btf;



	err = bpf_prog_load(target_obj_file, BPF_PROG_TYPE_UNSPEC,

			    &tgt_obj, &tgt_fd);

	if (CHECK(err, "tgt_prog_load", "file %s err %d errno %d\n",

		  target_obj_file, err, errno))

	if (!ASSERT_OK(err, "tgt_prog_load"))

		return;

	DECLARE_LIBBPF_OPTS(bpf_object_open_opts, opts,

			    .attach_prog_fd = tgt_fd,

			   );



	info_len = sizeof(prog_info);

	err = bpf_obj_get_info_by_fd(tgt_fd, &prog_info, &info_len);

	if (!ASSERT_OK(err, "tgt_fd_get_info"))

		goto close_prog;



	tgt_prog_id = prog_info.id;

	btf = bpf_object__btf(tgt_obj);



	link = calloc(sizeof(struct bpf_link *), prog_cnt);

	if (!ASSERT_OK_PTR(link, "link_ptr"))

		goto close_prog;



	prog = calloc(sizeof(struct bpf_program *), prog_cnt);

	if (CHECK(!link || !prog, "alloc_memory", "failed to alloc memory"))

	if (!ASSERT_OK_PTR(prog, "prog_ptr"))

		goto close_prog;



	obj = bpf_object__open_file(obj_file, &opts);

	if (CHECK(IS_ERR_OR_NULL(obj), "obj_open",

		  "failed to open %s: %ld\n", obj_file,

		  PTR_ERR(obj)))

	if (!ASSERT_OK_PTR(obj, "obj_open"))

		goto close_prog;



	err = bpf_object__load(obj);

	if (CHECK(err, "obj_load", "err %d\n", err))

	if (!ASSERT_OK(err, "obj_load"))

		goto close_prog;



	for (i = 0; i < prog_cnt; i++) {

		struct bpf_link_info link_info;

		char *tgt_name;

		__s32 btf_id;



		tgt_name = strstr(prog_name[i], "/");

		if (!ASSERT_OK_PTR(tgt_name, "tgt_name"))

			goto close_prog;

		btf_id = btf__find_by_name_kind(btf, tgt_name + 1, BTF_KIND_FUNC);



		prog[i] = bpf_object__find_program_by_title(obj, prog_name[i]);

		if (CHECK(!prog[i], "find_prog", "prog %s not found\n", prog_name[i]))

		if (!ASSERT_OK_PTR(prog[i], prog_name[i]))

			goto close_prog;



		link[i] = bpf_program__attach_trace(prog[i]);

		if (CHECK(IS_ERR(link[i]), "attach_trace", "failed to link\n"))

		if (!ASSERT_OK_PTR(link[i], "attach_trace"))

			goto close_prog;



		info_len = sizeof(link_info);

		memset(&link_info, 0, sizeof(link_info));

		err = bpf_obj_get_info_by_fd(bpf_link__fd(link[i]),

					     &link_info, &info_len);

		ASSERT_OK(err, "link_fd_get_info");

		ASSERT_EQ(link_info.tracing.attach_type,

			  bpf_program__get_expected_attach_type(prog[i]),

			  "link_attach_type");

		ASSERT_EQ(link_info.tracing.target_obj_id, tgt_prog_id, "link_tgt_obj_id");

		ASSERT_EQ(link_info.tracing.target_btf_id, btf_id, "link_tgt_btf_id");

	}



	if (cb) {
@@ -106,10 +137,9 @@ static void test_fexit_bpf2bpf_common(const char *obj_file, 
		goto close_prog;



	err = bpf_prog_test_run(tgt_fd, 1, &pkt_v6, sizeof(pkt_v6),

				NULL, NULL, &retval, &duration);

	CHECK(err || retval, "ipv6",

	      "err %d errno %d retval %d duration %d\n",

	      err, errno, retval, duration);

				NULL, NULL, &retval, NULL);

	ASSERT_OK(err, "prog_run");

	ASSERT_EQ(retval, 0, "prog_run_ret");



	if (check_data_map(obj, prog_cnt, false))

		goto close_prog;