Commit 462e768b authored by Dan Carpenter's avatar Dan Carpenter Committed by Joerg Roedel
Browse files

iommu/mediatek: Fix forever loop in error handling 



There is a typo so this loop does i++ where i-- was intended.  It will
result in looping until the kernel crashes.

Fixes: 26593928 ("iommu/mediatek: Add error path for loop of mm_dts_parse")
Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Reviewed-by: default avatarYong Wu <yong.wu@mediatek.com>
Link: https://lore.kernel.org/r/Y5C3mTam2nkbaz6o@kili


Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent 00ef8885

drivers/iommu/mtk_iommu.c

+1 −2
Original line number Diff line number Diff line
@@ -1159,8 +1159,7 @@ static int mtk_iommu_mm_dts_parse(struct device *dev, struct component_match **m 
	return 0;



err_larbdev_put:

	/* id may be not linear mapping, loop whole the array */

	for (i = MTK_LARB_NR_MAX - 1; i >= 0; i++) {

	for (i = MTK_LARB_NR_MAX - 1; i >= 0; i--) {

		if (!data->larb_imu[i].dev)

			continue;

		put_device(data->larb_imu[i].dev);