Commit 460d9cb6 authored by Samuel Holland's avatar Samuel Holland Committed by Jernej Skrabec
Browse files

soc: sunxi: sram: Return void from the release function 



There is no point in returning an error here, as the caller can do
nothing about it. In fact, all callers already ignore the return value.

Acked-by: default avatarJernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: default avatarSamuel Holland <samuel@sholland.org>
Reviewed-by: default avatarHeiko Stuebner <heiko@sntech.de>
Tested-by: default avatarHeiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20220815041248.53268-8-samuel@sholland.org


Signed-off-by: default avatarJernej Skrabec <jernej.skrabec@gmail.com>
parent e3c95edb

drivers/soc/sunxi/sunxi_sram.c

+3 −5
Original line number Diff line number Diff line
@@ -261,25 +261,23 @@ int sunxi_sram_claim(struct device *dev) 
}

EXPORT_SYMBOL(sunxi_sram_claim);



int sunxi_sram_release(struct device *dev)

void sunxi_sram_release(struct device *dev)

{

	const struct sunxi_sram_data *sram_data;

	struct sunxi_sram_desc *sram_desc;



	if (!dev || !dev->of_node)

		return -EINVAL;

		return;



	sram_data = sunxi_sram_of_parse(dev->of_node, NULL);

	if (IS_ERR(sram_data))

		return -EINVAL;

		return;



	sram_desc = to_sram_desc(sram_data);



	spin_lock(&sram_lock);

	sram_desc->claimed = false;

	spin_unlock(&sram_lock);



	return 0;

}

EXPORT_SYMBOL(sunxi_sram_release);

include/linux/soc/sunxi/sunxi_sram.h

+1 −1
Original line number Diff line number Diff line
@@ -14,6 +14,6 @@ 
#define _SUNXI_SRAM_H_



int sunxi_sram_claim(struct device *dev);

int sunxi_sram_release(struct device *dev);

void sunxi_sram_release(struct device *dev);



#endif /* _SUNXI_SRAM_H_ */