Commit 45fe7bef authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Greg Kroah-Hartman
Browse files

coresight: remove broken __exit annotations 



Functions that are annotated __exit are discarded for built-in drivers,
but the .remove callback in a device driver must still be kept around
to allow bind/unbind operations.

There is now a linker warning for the discarded symbol references:

`tmc_remove' referenced in section `.data' of drivers/hwtracing/coresight/coresight-tmc-core.o: defined in discarded section `.exit.text' of drivers/hwtracing/coresight/coresight-tmc-core.o
`tpiu_remove' referenced in section `.data' of drivers/hwtracing/coresight/coresight-tpiu.o: defined in discarded section `.exit.text' of drivers/hwtracing/coresight/coresight-tpiu.o
`etb_remove' referenced in section `.data' of drivers/hwtracing/coresight/coresight-etb10.o: defined in discarded section `.exit.text' of drivers/hwtracing/coresight/coresight-etb10.o
`static_funnel_remove' referenced in section `.data' of drivers/hwtracing/coresight/coresight-funnel.o: defined in discarded section `.exit.text' of drivers/hwtracing/coresight/coresight-funnel.o
`dynamic_funnel_remove' referenced in section `.data' of drivers/hwtracing/coresight/coresight-funnel.o: defined in discarded section `.exit.text' of drivers/hwtracing/coresight/coresight-funnel.o
`static_replicator_remove' referenced in section `.data' of drivers/hwtracing/coresight/coresight-replicator.o: defined in discarded section `.exit.text' of drivers/hwtracing/coresight/coresight-replicator.o
`dynamic_replicator_remove' referenced in section `.data' of drivers/hwtracing/coresight/coresight-replicator.o: defined in discarded section `.exit.text' of drivers/hwtracing/coresight/coresight-replicator.o
`catu_remove' referenced in section `.data' of drivers/hwtracing/coresight/coresight-catu.o: defined in discarded section `.exit.text' of drivers/hwtracing/coresight/coresight-catu.o

Remove all those annotations.

Fixes: 8b0cf826 ("coresight: stm: Allow to build coresight-stm as a module")
Reviewed-by: default avatarStephen Boyd <swboyd@chromium.org>
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
Link: https://lore.kernel.org/r/20201208182651.1597945-3-mathieu.poirier@linaro.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 83be0b84

drivers/hwtracing/coresight/coresight-catu.c

+1 −1
Original line number Diff line number Diff line
@@ -567,7 +567,7 @@ static int catu_probe(struct amba_device *adev, const struct amba_id *id) 
	return ret;

}



static int __exit catu_remove(struct amba_device *adev)

static int catu_remove(struct amba_device *adev)

{

	struct catu_drvdata *drvdata = dev_get_drvdata(&adev->dev);

drivers/hwtracing/coresight/coresight-cti-core.c

+1 −1
Original line number Diff line number Diff line
@@ -836,7 +836,7 @@ static void cti_device_release(struct device *dev) 
	if (drvdata->csdev_release)

		drvdata->csdev_release(dev);

}

static int __exit cti_remove(struct amba_device *adev)

static int cti_remove(struct amba_device *adev)

{

	struct cti_drvdata *drvdata = dev_get_drvdata(&adev->dev);

drivers/hwtracing/coresight/coresight-etb10.c

+1 −1
Original line number Diff line number Diff line
@@ -803,7 +803,7 @@ static int etb_probe(struct amba_device *adev, const struct amba_id *id) 
	return ret;

}



static int __exit etb_remove(struct amba_device *adev)

static int etb_remove(struct amba_device *adev)

{

	struct etb_drvdata *drvdata = dev_get_drvdata(&adev->dev);

drivers/hwtracing/coresight/coresight-etm3x-core.c

+2 −2
Original line number Diff line number Diff line
@@ -902,14 +902,14 @@ static int etm_probe(struct amba_device *adev, const struct amba_id *id) 
	return 0;

}



static void __exit clear_etmdrvdata(void *info)

static void clear_etmdrvdata(void *info)

{

	int cpu = *(int *)info;



	etmdrvdata[cpu] = NULL;

}



static int __exit etm_remove(struct amba_device *adev)

static int etm_remove(struct amba_device *adev)

{

	struct etm_drvdata *drvdata = dev_get_drvdata(&adev->dev);

drivers/hwtracing/coresight/coresight-etm4x-core.c

+2 −2
Original line number Diff line number Diff line
@@ -1575,14 +1575,14 @@ static struct amba_cs_uci_id uci_id_etm4[] = { 
	}

};



static void __exit clear_etmdrvdata(void *info)

static void clear_etmdrvdata(void *info)

{

	int cpu = *(int *)info;



	etmdrvdata[cpu] = NULL;

}



static int __exit etm4_remove(struct amba_device *adev)

static int etm4_remove(struct amba_device *adev)

{

	struct etmv4_drvdata *drvdata = dev_get_drvdata(&adev->dev);