Unverified Commit 45ee8b79 authored by Yang Li's avatar Yang Li Committed by Mark Brown
Browse files

regulator: add missing call to of_node_put() 



In one of the error paths of the for_each_child_of_node() loop,
add missing call to of_node_put().

Fix the following coccicheck warning:
./drivers/regulator/scmi-regulator.c:343:1-23: WARNING: Function
"for_each_child_of_node" should have of_node_put() before return around
line 347.

Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Signed-off-by: default avatarYang Li <yang.lee@linux.alibaba.com>
Link: https://lore.kernel.org/r/1614303575-27436-1-git-send-email-yang.lee@linux.alibaba.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 1e50433c

drivers/regulator/scmi-regulator.c

+3 −1
Original line number Diff line number Diff line
@@ -343,9 +343,11 @@ static int scmi_regulator_probe(struct scmi_device *sdev) 
	for_each_child_of_node(np, child) {

		ret = process_scmi_regulator_of_node(sdev, child, rinfo);

		/* abort on any mem issue */

		if (ret == -ENOMEM)

		if (ret == -ENOMEM) {

			of_node_put(child);

			return ret;

		}

	}



	/*

	 * Register a regulator for each valid regulator-DT-entry that we