Commit 45ed9337 authored by Shaokun Zhang's avatar Shaokun Zhang Committed by Joerg Roedel
Browse files

iommu/amd: Remove duplicate check of devid 



'devid' has been checked in function check_device, no need to double
check and clean up this.

Cc: Joerg Roedel <joro@8bytes.org>
Cc: Will Deacon <will@kernel.org>
Signed-off-by: default avatarShaokun Zhang <zhangshaokun@hisilicon.com>
Link: https://lore.kernel.org/r/1617939040-35579-1-git-send-email-zhangshaokun@hisilicon.com


Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent 268aa454

drivers/iommu/amd/iommu.c

+1 −8
Original line number Diff line number Diff line
@@ -1685,9 +1685,6 @@ static struct iommu_device *amd_iommu_probe_device(struct device *dev) 
		return ERR_PTR(-ENODEV);



	devid = get_device_id(dev);

	if (devid < 0)

		return ERR_PTR(devid);



	iommu = amd_iommu_rlookup_table[devid];



	if (dev_iommu_priv_get(dev))
@@ -1989,16 +1986,12 @@ static void amd_iommu_detach_device(struct iommu_domain *dom, 
				    struct device *dev)

{

	struct iommu_dev_data *dev_data = dev_iommu_priv_get(dev);

	int devid = get_device_id(dev);

	struct amd_iommu *iommu;

	int devid;



	if (!check_device(dev))

		return;



	devid = get_device_id(dev);

	if (devid < 0)

		return;



	if (dev_data->domain != NULL)

		detach_device(dev);