Commit 45e8867a authored Feb 19, 2023 by Ian Rogers Committed by Arnaldo Carvalho de Melo Feb 19, 2023

perf jevent: Parse metric thresholds



Parse the metric threshold and add to the pmu-events.c file. The
metric isn't parsed as the parser uses python's parser and will break
the operator precedence.

Signed-off-by: Ian Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Andrii Nakryiko <andrii@kernel.org>
Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Cc: Caleb Biggers <caleb.biggers@intel.com>
Cc: Eduard Zingerman <eddyz87@gmail.com>
Cc: Florian Fischer <florian.fischer@muhq.space>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: James Clark <james.clark@arm.com>
Cc: Jing Zhang <renyu.zj@linux.alibaba.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: John Garry <john.g.garry@oracle.com>
Cc: Kajol Jain <kjain@linux.ibm.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Perry Taylor <perry.taylor@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ravi Bangoria <ravi.bangoria@amd.com>
Cc: Sandipan Das <sandipan.das@amd.com>
Cc: Sean Christopherson <seanjc@google.com>
Cc: Stephane Eranian <eranian@google.com>
Cc: Suzuki Poulouse <suzuki.poulose@arm.com>
Cc: Xing Zhengjun <zhengjun.xing@linux.intel.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-stm32@st-md-mailman.stormreply.com
Link: https://lore.kernel.org/r/20230219092848.639226-34-irogers@google.com


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 77d78b4c

tools/perf/pmu-events/jevents.py

+6 −1

Original line number	Diff line number	Diff line
		@@ -51,7 +51,7 @@ _json_event_attributes = [

		# Attributes that are in pmu_metric rather than pmu_event.
		_json_metric_attributes = [
		'metric_name', 'metric_group', 'metric_expr', 'desc',
		'metric_name', 'metric_group', 'metric_expr', 'metric_threshold', 'desc',
		'long_desc', 'unit', 'compat', 'aggr_mode', 'event_grouping'
		]
		# Attributes that are bools or enum int values, encoded as '0', '1',...
		@@ -306,6 +306,9 @@ class JsonEvent:
		self.metric_expr = None
		if 'MetricExpr' in jd:
		self.metric_expr = metric.ParsePerfJson(jd['MetricExpr']).Simplify()
		# Note, the metric formula for the threshold isn't parsed as the &
		# and > have incorrect precedence.
		self.metric_threshold = jd.get('MetricThreshold')

		arch_std = jd.get('ArchStdEvent')
		if precise and self.desc and '(Precise Event)' not in self.desc:
		@@ -362,6 +365,8 @@ class JsonEvent:
		# Convert parsed metric expressions into a string. Slashes
		# must be doubled in the file.
		x = x.ToPerfJson().replace('\\', '\\\\')
		if metric and x and attr == 'metric_threshold':
		x = x.replace('\\', '\\\\')
		if attr in _json_enum_attributes:
		s += x if x else '0'
		else:

tools/perf/pmu-events/pmu-events.h

+1 −0

Original line number	Diff line number	Diff line
		@@ -54,6 +54,7 @@ struct pmu_metric {
		const char *metric_name;
		const char *metric_group;
		const char *metric_expr;
		const char *metric_threshold;
		const char *unit;
		const char *compat;
		const char *desc;