Commit 45d87b85 authored by Christian König's avatar Christian König Committed by Alex Deucher
Browse files

drm/amdgpu: cleanup gmc_v10_0_process_interrupt a bit 



Return early in case of a ratelimit and don't print leading zeros for
the address.

Signed-off-by: default avatarChristian König <christian.koenig@amd.com>
Reviewed-by: default avatarFelix Kuehling <Felix.Kuehling@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 18e1a6c9

drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c

+20 −18
Original line number Diff line number Diff line
@@ -95,6 +95,7 @@ static int gmc_v10_0_process_interrupt(struct amdgpu_device *adev, 
				       struct amdgpu_iv_entry *entry)

{

	struct amdgpu_vmhub *hub = &adev->vmhub[entry->vmid_src];

	struct amdgpu_task_info task_info;

	uint32_t status = 0;

	u64 addr;
@@ -115,8 +116,8 @@ static int gmc_v10_0_process_interrupt(struct amdgpu_device *adev, 
		WREG32_P(hub->vm_l2_pro_fault_cntl, 1, ~1);

	}



	if (printk_ratelimit()) {

		struct amdgpu_task_info task_info;

	if (!printk_ratelimit())

		return 0;



	memset(&task_info, 0, sizeof(struct amdgpu_task_info));

	amdgpu_vm_get_task_info(adev, entry->pasid, &task_info);
@@ -128,11 +129,12 @@ static int gmc_v10_0_process_interrupt(struct amdgpu_device *adev, 
		entry->src_id, entry->ring_id, entry->vmid,

		entry->pasid, task_info.process_name, task_info.tgid,

		task_info.task_name, task_info.pid);

		dev_err(adev->dev, "  in page starting at address 0x%016llx from client %d\n",

	dev_err(adev->dev, "  in page starting at address 0x%012llx from client %d\n",

		addr, entry->client_id);



	if (!amdgpu_sriov_vf(adev))

			hub->vmhub_funcs->print_l2_protection_fault_status(adev, status);

	}

		hub->vmhub_funcs->print_l2_protection_fault_status(adev,

								   status);



	return 0;

}