Commit 45c04024 authored by Thomas Gleixner's avatar Thomas Gleixner
Browse files

PCI/MSI: Remove unused pci_dev_has_special_msi_domain() 



The check for special MSI domains like VMD which prevents the interrupt
remapping code to overwrite device::msi::domain is not longer required and
has been replaced by an x86 specific version which is aware of MSI parent
domains.

Remove it.

Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Reviewed-by: default avatarKevin Tian <kevin.tian@intel.com>
Acked-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Acked-by: default avatarMarc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20221124232326.093093200@linutronix.de
parent b6d5fc3a

drivers/pci/msi/irqdomain.c

+0 −21
Original line number Diff line number Diff line
@@ -414,24 +414,3 @@ struct irq_domain *pci_msi_get_device_domain(struct pci_dev *pdev) 
					     DOMAIN_BUS_PCI_MSI);

	return dom;

}
 


/**

 * pci_dev_has_special_msi_domain - Check whether the device is handled by

 *				    a non-standard PCI-MSI domain

 * @pdev:	The PCI device to check.

 *

 * Returns: True if the device irqdomain or the bus irqdomain is

 * non-standard PCI/MSI.

 */

bool pci_dev_has_special_msi_domain(struct pci_dev *pdev)

{

	struct irq_domain *dom = dev_get_msi_domain(&pdev->dev);



	if (!dom)

		dom = dev_get_msi_domain(&pdev->bus->dev);



	if (!dom)

		return true;



	return dom->bus_token != DOMAIN_BUS_PCI_MSI;

}

include/linux/msi.h

+0 −1
Original line number Diff line number Diff line
@@ -617,7 +617,6 @@ struct irq_domain *pci_msi_create_irq_domain(struct fwnode_handle *fwnode, 
					     struct irq_domain *parent);

u32 pci_msi_domain_get_msi_rid(struct irq_domain *domain, struct pci_dev *pdev);

struct irq_domain *pci_msi_get_device_domain(struct pci_dev *pdev);

bool pci_dev_has_special_msi_domain(struct pci_dev *pdev);

#else /* CONFIG_PCI_MSI */

static inline struct irq_domain *pci_msi_get_device_domain(struct pci_dev *pdev)

{