Commit 45a92f45 authored by sunliming's avatar sunliming Committed by Alex Deucher
Browse files

drm/amd/display: Fix variable dereferenced before check 



Fixes the following smatch warning:

drivers/gpu/drm/amd/amdgpu/../display/dc/dc_dmub_srv.c:311 dc_dmub_srv_p_state_delegate()
warn: variable dereferenced before check 'dc' (see line 309)

Reported-by: default avatarkernel test robot <lkp@intel.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarsunliming <sunliming@kylinos.cn>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 1d5d1947

drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c

+3 −1
Original line number Diff line number Diff line
@@ -323,11 +323,13 @@ bool dc_dmub_srv_p_state_delegate(struct dc *dc, bool should_manage_pstate, stru 
	struct dmub_cmd_fw_assisted_mclk_switch_config *config_data = &cmd.fw_assisted_mclk_switch.config_data;

	int i = 0;

	int ramp_up_num_steps = 1; // TODO: Ramp is currently disabled. Reenable it.

	uint8_t visual_confirm_enabled = dc->debug.visual_confirm == VISUAL_CONFIRM_FAMS;

	uint8_t visual_confirm_enabled;



	if (dc == NULL)

		return false;



	visual_confirm_enabled = dc->debug.visual_confirm == VISUAL_CONFIRM_FAMS;



	// Format command.

	cmd.fw_assisted_mclk_switch.header.type = DMUB_CMD__FW_ASSISTED_MCLK_SWITCH;

	cmd.fw_assisted_mclk_switch.header.sub_type = DMUB_CMD__FAMS_SETUP_FW_CTRL;