Commit 45a20cdd authored by Justin Tee's avatar Justin Tee Committed by Baogen Shang
Browse files

scsi: lpfc: Fix possible memory leak in lpfc_rcv_padisc() 

stable inclusion
from stable-v5.10.215
commit c473288f27d15014447de5a891bdf22a0695847a
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I9J6AL
CVE: NA

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-5.10.y&id=c473288f27d15014447de5a891bdf22a0695847a



-------------------------

[ Upstream commit 2ae917d4bcab80ab304b774d492e2fcd6c52c06b ]

The call to lpfc_sli4_resume_rpi() in lpfc_rcv_padisc() may return an
unsuccessful status.  In such cases, the elsiocb is not issued, the
completion is not called, and thus the elsiocb resource is leaked.

Check return value after calling lpfc_sli4_resume_rpi() and conditionally
release the elsiocb resource.

Signed-off-by: default avatarJustin Tee <justin.tee@broadcom.com>
Link: https://lore.kernel.org/r/20240131185112.149731-3-justintee8345@gmail.com


Reviewed-by: default avatarHimanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarBaogen Shang <baogen.shang@windriver.com>
parent 34c4be6c

drivers/scsi/lpfc/lpfc_nportdisc.c

+4 −2
Original line number Diff line number Diff line
@@ -784,8 +784,10 @@ lpfc_rcv_padisc(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp, 
				/* Save the ELS cmd */

				elsiocb->drvrTimeout = cmd;



				lpfc_sli4_resume_rpi(ndlp,

					lpfc_mbx_cmpl_resume_rpi, elsiocb);

				if (lpfc_sli4_resume_rpi(ndlp,

						lpfc_mbx_cmpl_resume_rpi,

						elsiocb))

					kfree(elsiocb);

				goto out;

			}

		}