Commit 458f5d92 authored by Martin Habets's avatar Martin Habets Committed by David S. Miller
Browse files

sfc: Do not free an empty page_ring 



When the page_ring is not used page_ptr_mask is 0.
Do not dereference page_ring[0] in this case.

Fixes: 2768935a ("sfc: reuse pages to avoid DMA mapping/unmapping costs")
Reported-by: default avatarTaehee Yoo <ap420073@gmail.com>
Signed-off-by: default avatarMartin Habets <habetsm.xilinx@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2baed4f9

drivers/net/ethernet/sfc/rx_common.c

+3 −0
Original line number Diff line number Diff line
@@ -150,6 +150,9 @@ static void efx_fini_rx_recycle_ring(struct efx_rx_queue *rx_queue) 
	struct efx_nic *efx = rx_queue->efx;

	int i;



	if (unlikely(!rx_queue->page_ring))

		return;



	/* Unmap and release the pages in the recycle ring. Remove the ring. */

	for (i = 0; i <= rx_queue->page_ptr_mask; i++) {

		struct page *page = rx_queue->page_ring[i];