Commit 4581065f authored by Chengchang Tang's avatar Chengchang Tang Committed by Juan Zhou
Browse files

RDMA/hns: Alloc MTR memory before alloc_mtt() 

maillist inclusion
category: feature
bugzilla: https://gitee.com/openeuler/kernel/issues/I91AFK
CVE: NA

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6afc859518319d78164ec616e736af45acbf1cec



----------------------------------------------------------------------

MTR memory allocation do not depend on allocation of mtt.

This patch moves the allocation of mtr before mtt in preparation for
the following optimization.

Signed-off-by: default avatarChengchang Tang <tangchengchang@huawei.com>
Signed-off-by: default avatarJunxian Huang <huangjunxian6@hisilicon.com>
Link: https://lore.kernel.org/r/20240113085935.2838701-4-huangjunxian6@hisilicon.com


Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
Signed-off-by: default avatarJuan Zhou <zhoujuan51@h-partners.com>
parent 9d62e311

drivers/infiniband/hw/hns/hns_roce_mr.c

+27 −20
Original line number Diff line number Diff line
@@ -695,7 +695,7 @@ static int mtr_alloc_bufs(struct hns_roce_dev *hr_dev, struct hns_roce_mtr *mtr, 
		mtr->umem = NULL;

		mtr->kmem = hns_roce_buf_alloc(hr_dev, total_size,

					       buf_attr->page_shift,

					       mtr->hem_cfg.is_direct ?

					       !mtr_has_mtt(buf_attr) ?

					       HNS_ROCE_BUF_DIRECT : 0);

		if (IS_ERR(mtr->kmem)) {

			ibdev_err(ibdev, "failed to alloc kmem, ret = %ld.\n",
@@ -1054,45 +1054,52 @@ int hns_roce_mtr_create(struct hns_roce_dev *hr_dev, struct hns_roce_mtr *mtr, 
			unsigned int ba_page_shift, struct ib_udata *udata,

			unsigned long user_addr)

{

	u64 pgoff = udata ? user_addr & ~PAGE_MASK : 0;

	struct ib_device *ibdev = &hr_dev->ib_dev;

	int ret;



	ret = mtr_init_buf_cfg(hr_dev, buf_attr, &mtr->hem_cfg,

			       udata ? user_addr & ~PAGE_MASK : 0);

	if (ret)

		return ret;



	ret = mtr_alloc_mtt(hr_dev, mtr, ba_page_shift);

	if (ret) {

		ibdev_err(ibdev, "failed to alloc mtr mtt, ret = %d.\n", ret);

		return ret;

	}



	/* The caller has its own buffer list and invokes the hns_roce_mtr_map()

	 * to finish the MTT configuration.

	 */

	if (buf_attr->mtt_only) {

		mtr->umem = NULL;

		mtr->kmem = NULL;

		return 0;

	} else {

		ret = mtr_alloc_bufs(hr_dev, mtr, buf_attr, udata, user_addr);

		if (ret) {

			ibdev_err(ibdev,

				  "failed to alloc mtr bufs, ret = %d.\n", ret);

			return ret;

		}

	}



	ret = mtr_alloc_bufs(hr_dev, mtr, buf_attr, udata, user_addr);

	ret = mtr_init_buf_cfg(hr_dev, buf_attr, &mtr->hem_cfg, pgoff);

	if (ret)

		goto err_init_buf;



	ret = mtr_alloc_mtt(hr_dev, mtr, ba_page_shift);

	if (ret) {

		ibdev_err(ibdev, "failed to alloc mtr bufs, ret = %d.\n", ret);

		goto err_alloc_mtt;

		ibdev_err(ibdev, "failed to alloc mtr mtt, ret = %d.\n", ret);

		goto err_init_buf;

	}



	if (buf_attr->mtt_only)

		return 0;



	/* Write buffer's dma address to MTT */

	ret = mtr_map_bufs(hr_dev, mtr);

	if (ret)

	if (ret) {

		ibdev_err(ibdev, "failed to map mtr bufs, ret = %d.\n", ret);

	else

		goto err_alloc_mtt;

	}



	return 0;



	mtr_free_bufs(hr_dev, mtr);

err_alloc_mtt:

	mtr_free_mtt(hr_dev, mtr);

err_init_buf:

	mtr_free_bufs(hr_dev, mtr);



	return ret;

}