Commit 457a02f0 authored by Maciej Fijalkowski's avatar Maciej Fijalkowski Committed by Tony Nguyen
Browse files

ice: avoid XDP checks in ice_clean_tx_irq() 



Commit 9610bd98 ("ice: optimize XDP_TX workloads") introduced Tx IRQ
cleaning routine dedicated for XDP rings. Currently it is impossible to
call ice_clean_tx_irq() against XDP ring, so it is safe to drop
ice_ring_is_xdp() calls in there.

Reviewed-by: default avatarAlexander Lobakin <alexandr.lobakin@intel.com>
Signed-off-by: default avatarMaciej Fijalkowski <maciej.fijalkowski@intel.com>
Tested-by: Kiran Bhandare <kiranx.bhandare@intel.com>  (A Contingent Worker at Intel)
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent ad24d9eb

drivers/net/ethernet/intel/ice/ice_txrx.c

+1 −6
Original line number Diff line number Diff line
@@ -223,7 +223,6 @@ static bool ice_clean_tx_irq(struct ice_tx_ring *tx_ring, int napi_budget) 
	struct ice_tx_buf *tx_buf;



	/* get the bql data ready */

	if (!ice_ring_is_xdp(tx_ring))

	netdev_txq_bql_complete_prefetchw(txring_txq(tx_ring));



	tx_buf = &tx_ring->tx_buf[i];
@@ -313,10 +312,6 @@ static bool ice_clean_tx_irq(struct ice_tx_ring *tx_ring, int napi_budget) 
	tx_ring->next_to_clean = i;



	ice_update_tx_ring_stats(tx_ring, total_pkts, total_bytes);



	if (ice_ring_is_xdp(tx_ring))

		return !!budget;



	netdev_tx_completed_queue(txring_txq(tx_ring), total_pkts, total_bytes);



#define TX_WAKE_THRESHOLD ((s16)(DESC_NEEDED * 2))