Commit 455a844d authored by Jiapeng Chong's avatar Jiapeng Chong Committed by Jens Axboe
Browse files

block: fix boolreturn.cocci warning 



Return statements in functions returning bool should use true/false
instead of 1/0.

./block/bio.c:1081:9-10: WARNING: return of 0/1 in function
'bio_add_folio' with return type bool.

Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Signed-off-by: default avatarJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarChaitanya Kulkarni <kch@nvidia.com>
Link: https://lore.kernel.org/r/20220128043454.68927-1-jiapeng.chong@linux.alibaba.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 3767c902

block/bio.c

+1 −1
Original line number Diff line number Diff line
@@ -1078,7 +1078,7 @@ bool bio_add_folio(struct bio *bio, struct folio *folio, size_t len, 
		   size_t off)

{

	if (len > UINT_MAX || off > UINT_MAX)

		return 0;

		return false;

	return bio_add_page(bio, &folio->page, len, off) > 0;

}