Commit 455896c5 authored by Yongzhi Liu's avatar Yongzhi Liu Committed by Vinod Koul
Browse files

dmaengine: shdma: Fix runtime PM imbalance on error 



pm_runtime_get_() increments the runtime PM usage counter even
when it returns an error code, thus a matching decrement is needed on
the error handling path to keep the counter balanced.

Signed-off-by: default avatarYongzhi Liu <lyz_cs@pku.edu.cn>
Link: https://lore.kernel.org/r/1642311296-87020-1-git-send-email-lyz_cs@pku.edu.cn


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent da2ad87f

drivers/dma/sh/shdma-base.c

+3 −1
Original line number Diff line number Diff line
@@ -115,8 +115,10 @@ static dma_cookie_t shdma_tx_submit(struct dma_async_tx_descriptor *tx) 
		ret = pm_runtime_get(schan->dev);



		spin_unlock_irq(&schan->chan_lock);

		if (ret < 0)

		if (ret < 0) {

			dev_err(schan->dev, "%s(): GET = %d\n", __func__, ret);

			pm_runtime_put(schan->dev);

		}



		pm_runtime_barrier(schan->dev);