Commit 45542479 authored by David Howells's avatar David Howells Committed by David S. Miller
Browse files

[NET]: Fix uninitialised variable in ip_frag_reasm() 



Fix uninitialised variable in ip_frag_reasm().  err should be set to
-ENOMEM if the initial call of skb_clone() fails.

Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 13996378

net/ipv4/ip_fragment.c

+1 −2
Original line number Diff line number Diff line
@@ -486,7 +486,6 @@ static int ip_frag_reasm(struct ipq *qp, struct sk_buff *prev, 
	if (prev) {

		head = prev->next;

		fp = skb_clone(head, GFP_ATOMIC);



		if (!fp)

			goto out_nomem;
@@ -512,7 +511,6 @@ static int ip_frag_reasm(struct ipq *qp, struct sk_buff *prev, 
		goto out_oversize;



	/* Head of list must not be cloned. */

	err = -ENOMEM;

	if (skb_cloned(head) && pskb_expand_head(head, 0, 0, GFP_ATOMIC))

		goto out_nomem;
@@ -568,6 +566,7 @@ static int ip_frag_reasm(struct ipq *qp, struct sk_buff *prev, 
out_nomem:

	LIMIT_NETDEBUG(KERN_ERR "IP: queue_glue: no memory for gluing "

			      "queue %p\n", qp);

	err = -ENOMEM;

	goto out_fail;

out_oversize:

	if (net_ratelimit())