Commit 453bd913 authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

fbdev: Don't re-validate info->state in fb_ops implementations 



The file-op entry points fb_read() and fb_write() verify that
info->state has been set to FBINFO_STATE_RUNNING. Remove the same
test from the implementations of struct fb_ops.{fb_read,fb_write}.

v2:
	* also remove test from ivtvfb, braodsheetfb, hecubafb and
	  metronomefb (Geert)

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Tested-by: default avatarSui Jingfeng <suijingfeng@loongson.cn>
Reviewed-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Acked-by: default avatarHelge Deller <deller@gmx.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230428122452.4856-17-tzimmermann@suse.de
parent f06875dc

drivers/media/pci/ivtv/ivtvfb.c

+0 −3
Original line number Diff line number Diff line
@@ -378,9 +378,6 @@ static ssize_t ivtvfb_write(struct fb_info *info, const char __user *buf, 
	unsigned long dma_size;

	u16 lead = 0, tail = 0;



	if (info->state != FBINFO_STATE_RUNNING)

		return -EPERM;



	total_size = info->screen_size;



	if (total_size == 0)

drivers/video/fbdev/broadsheetfb.c

+0 −3
Original line number Diff line number Diff line
@@ -1013,9 +1013,6 @@ static ssize_t broadsheetfb_write(struct fb_info *info, const char __user *buf, 
	int err = 0;

	unsigned long total_size;



	if (info->state != FBINFO_STATE_RUNNING)

		return -EPERM;



	total_size = info->fix.smem_len;



	if (p > total_size)

drivers/video/fbdev/core/fb_sys_fops.c

+0 −6
Original line number Diff line number Diff line
@@ -22,9 +22,6 @@ ssize_t fb_sys_read(struct fb_info *info, char __user *buf, size_t count, 
	unsigned long total_size, c;

	ssize_t ret;



	if (info->state != FBINFO_STATE_RUNNING)

		return -EPERM;



	total_size = info->screen_size;



	if (total_size == 0)
@@ -64,9 +61,6 @@ ssize_t fb_sys_write(struct fb_info *info, const char __user *buf, 
	unsigned long total_size, c;

	size_t ret;



	if (info->state != FBINFO_STATE_RUNNING)

		return -EPERM;



	total_size = info->screen_size;



	if (total_size == 0)

drivers/video/fbdev/hecubafb.c

+0 −3
Original line number Diff line number Diff line
@@ -163,9 +163,6 @@ static ssize_t hecubafb_write(struct fb_info *info, const char __user *buf, 
	int err = 0;

	unsigned long total_size;



	if (info->state != FBINFO_STATE_RUNNING)

		return -EPERM;



	total_size = info->fix.smem_len;



	if (p > total_size)

drivers/video/fbdev/metronomefb.c

+0 −3
Original line number Diff line number Diff line
@@ -523,9 +523,6 @@ static ssize_t metronomefb_write(struct fb_info *info, const char __user *buf, 
	int err = 0;

	unsigned long total_size;



	if (info->state != FBINFO_STATE_RUNNING)

		return -EPERM;



	total_size = info->fix.smem_len;



	if (p > total_size)