Commit 452af7dc authored by Yu Kuai's avatar Yu Kuai Committed by Jens Axboe
Browse files

block, bfq: don't return bfqg from __bfq_bic_change_cgroup() 



The return value is not used, hence remove it.

Signed-off-by: default avatarYu Kuai <yukuai3@huawei.com>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20221214033155.3455754-2-yukuai1@huaweicloud.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 64dc8c73

block/bfq-cgroup.c

+3 −5
Original line number Diff line number Diff line
@@ -724,7 +724,7 @@ void bfq_bfqq_move(struct bfq_data *bfqd, struct bfq_queue *bfqq, 
 * sure that the reference to cgroup is valid across the call (see

 * comments in bfq_bic_update_cgroup on this issue)

 */

static void *__bfq_bic_change_cgroup(struct bfq_data *bfqd,

static void __bfq_bic_change_cgroup(struct bfq_data *bfqd,

				    struct bfq_io_cq *bic,

				    struct bfq_group *bfqg)

{
@@ -776,8 +776,6 @@ static void *__bfq_bic_change_cgroup(struct bfq_data *bfqd, 
			}

		}

	}



	return bfqg;

}



void bfq_bic_update_cgroup(struct bfq_io_cq *bic, struct bio *bio)