Commit 452014d2 authored by Nadav Amit's avatar Nadav Amit Committed by Joerg Roedel
Browse files

iommu/vt-d: Remove unnecassary qi clflushes 



According to the manual: "Hardware access to ...  invalidation queue ...
are always coherent."

Remove unnecassary clflushes accordingly.

Signed-off-by: default avatarNadav Amit <namit@vmware.com>
Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent ffb2d1eb

drivers/iommu/dmar.c

+0 −5
Original line number Original line Diff line number Diff line
@@ -1167,8 +1167,6 @@ static int qi_check_fault(struct intel_iommu *iommu, int index) 
				(unsigned long long)qi->desc[index].high);

				(unsigned long long)qi->desc[index].high);

			memcpy(&qi->desc[index], &qi->desc[wait_index],

			memcpy(&qi->desc[index], &qi->desc[wait_index],

					sizeof(struct qi_desc));

					sizeof(struct qi_desc));

			__iommu_flush_cache(iommu, &qi->desc[index],

					sizeof(struct qi_desc));

			writel(DMA_FSTS_IQE, iommu->reg + DMAR_FSTS_REG);

			writel(DMA_FSTS_IQE, iommu->reg + DMAR_FSTS_REG);

			return -EINVAL;

			return -EINVAL;

		}

		}
@@ -1243,9 +1241,6 @@ int qi_submit_sync(struct qi_desc *desc, struct intel_iommu *iommu) 




	hw[wait_index] = wait_desc;

	hw[wait_index] = wait_desc;





	__iommu_flush_cache(iommu, &hw[index], sizeof(struct qi_desc));

	__iommu_flush_cache(iommu, &hw[wait_index], sizeof(struct qi_desc));



	qi->free_head = (qi->free_head + 2) % QI_LENGTH;

	qi->free_head = (qi->free_head + 2) % QI_LENGTH;

	qi->free_cnt -= 2;

	qi->free_cnt -= 2;