Commit 4506f23e authored by Olga Kornievskaia's avatar Olga Kornievskaia Committed by Anna Schumaker
Browse files

NFSv4.1: fix zero value filehandle in post open getattr 



Currently, if the OPEN compound experiencing an error and needs to
get the file attributes separately, it will send a stand alone
GETATTR but it would use the filehandle from the results of
the OPEN compound. In case of the CLAIM_FH OPEN, nfs_openres's fh
is zero value. That generate a GETATTR that's sent with a zero
value filehandle, and results in the server returning an error.

Instead, for the CLAIM_FH OPEN, take the filehandle that was used
in the PUTFH of the OPEN compound.

Signed-off-by: default avatarOlga Kornievskaia <kolga@netapp.com>
Reviewed-by: default avatarBenjamin Coddington <bcodding@redhat.com>
Signed-off-by: default avatarAnna Schumaker <Anna.Schumaker@Netapp.com>
parent 806a3bc4

fs/nfs/nfs4proc.c

+5 −1
Original line number Diff line number Diff line
@@ -2703,8 +2703,12 @@ static int _nfs4_proc_open(struct nfs4_opendata *data, 
			return status;

	}

	if (!(o_res->f_attr->valid & NFS_ATTR_FATTR)) {

		struct nfs_fh *fh = &o_res->fh;



		nfs4_sequence_free_slot(&o_res->seq_res);

		nfs4_proc_getattr(server, &o_res->fh, o_res->f_attr, NULL);

		if (o_arg->claim == NFS4_OPEN_CLAIM_FH)

			fh = NFS_FH(d_inode(data->dentry));

		nfs4_proc_getattr(server, fh, o_res->f_attr, NULL);

	}

	return 0;

}