Commit 44e261c7 authored by Yang Yingliang's avatar Yang Yingliang Committed by David S. Miller
Browse files

cxgb4: clip_tbl: use list_del_init instead of list_del/INIT_LIST_HEAD 



Using list_del_init() instead of list_del() + INIT_LIST_HEAD()
to simpify the code.

Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 46212b69

drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c

+2 −4
Original line number Diff line number Diff line
@@ -106,8 +106,7 @@ int cxgb4_clip_get(const struct net_device *dev, const u32 *lip, u8 v6) 
	if (!list_empty(&ctbl->ce_free_head)) {

		ce = list_first_entry(&ctbl->ce_free_head,

				      struct clip_entry, list);

		list_del(&ce->list);

		INIT_LIST_HEAD(&ce->list);

		list_del_init(&ce->list);

		spin_lock_init(&ce->lock);

		refcount_set(&ce->refcnt, 0);

		atomic_dec(&ctbl->nfree);
@@ -179,8 +178,7 @@ void cxgb4_clip_release(const struct net_device *dev, const u32 *lip, u8 v6) 
	write_lock_bh(&ctbl->lock);

	spin_lock_bh(&ce->lock);

	if (refcount_dec_and_test(&ce->refcnt)) {

		list_del(&ce->list);

		INIT_LIST_HEAD(&ce->list);

		list_del_init(&ce->list);

		list_add_tail(&ce->list, &ctbl->ce_free_head);

		atomic_inc(&ctbl->nfree);

		if (v6)