Commit 44c769de authored by Pavel Begunkov's avatar Pavel Begunkov Committed by Jens Axboe
Browse files

io_uring: optimise non-eventfd post-event 



Eventfd is not the canonical way of using io_uring, annotate
io_should_trigger_evfd() with likely so it improves code generation for
non-eventfd branch.

Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/42fdaa51c68d39479f02cef4fe5bcb24624d60fa.1618101759.git.asml.silence@gmail.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 4af3417a

fs/io_uring.c

+2 −4
Original line number Original line Diff line number Diff line
@@ -1355,13 +1355,11 @@ static struct io_uring_cqe *io_get_cqring(struct io_ring_ctx *ctx) 




static inline bool io_should_trigger_evfd(struct io_ring_ctx *ctx)

static inline bool io_should_trigger_evfd(struct io_ring_ctx *ctx)

{

{

	if (!ctx->cq_ev_fd)

	if (likely(!ctx->cq_ev_fd))

		return false;

		return false;

	if (READ_ONCE(ctx->rings->cq_flags) & IORING_CQ_EVENTFD_DISABLED)

	if (READ_ONCE(ctx->rings->cq_flags) & IORING_CQ_EVENTFD_DISABLED)

		return false;

		return false;

	if (!ctx->eventfd_async)

	return !ctx->eventfd_async || io_wq_current_is_worker();

		return true;

	return io_wq_current_is_worker();

}

}





static void io_cqring_ev_posted(struct io_ring_ctx *ctx)

static void io_cqring_ev_posted(struct io_ring_ctx *ctx)