Commit 44aee8ea authored by Shay Drory's avatar Shay Drory Committed by Saeed Mahameed
Browse files

net/mlx5: Fix io_eq_size and event_eq_size params validation 



io_eq_size and event_eq_size params are of param type
DEVLINK_PARAM_TYPE_U32. But, the validation callback is addressing them
as DEVLINK_PARAM_TYPE_U16.

This cause mismatch in validation in big-endian systems, in which
values in range were rejected while 268500991 was accepted.
Fix it by checking the U32 value in the validation callback.

Fixes: 0844fa5f ("net/mlx5: Let user configure io_eq_size param")
Signed-off-by: default avatarShay Drory <shayd@nvidia.com>
Reviewed-by: default avatarMoshe Shemesh <moshe@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 2a35b2c2

drivers/net/ethernet/mellanox/mlx5/core/devlink.c

+1 −1
Original line number Diff line number Diff line
@@ -563,7 +563,7 @@ static int mlx5_devlink_eq_depth_validate(struct devlink *devlink, u32 id, 
					  union devlink_param_value val,

					  struct netlink_ext_ack *extack)

{

	return (val.vu16 >= 64 && val.vu16 <= 4096) ? 0 : -EINVAL;

	return (val.vu32 >= 64 && val.vu32 <= 4096) ? 0 : -EINVAL;

}



static const struct devlink_param mlx5_devlink_params[] = {