Commit 44acdbb2 authored by David Gow's avatar David Gow Committed by Shuah Khan
Browse files

kunit: Add gnu_printf specifiers 



Some KUnit functions use variable arguments to implement a printf-like
format string. Use the __printf() attribute to let the compiler warn if
invalid format strings are passed in.

If the kernel is build with W=1, it complained about the lack of these
specifiers, e.g.:
../lib/kunit/test.c:72:2: warning: function ‘kunit_log_append’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]

Signed-off-by: default avatarDavid Gow <davidgow@google.com>
Reviewed-by: default avatarDaniel Latypov <dlatypov@google.com>
Acked-by: default avatarBrendan Higgins <brendanhiggins@google.com>
Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
parent 255ede3b

include/kunit/test.h

+1 −1
Original line number Diff line number Diff line
@@ -610,7 +610,7 @@ static inline void *kunit_kzalloc(struct kunit *test, size_t size, gfp_t gfp) 


void kunit_cleanup(struct kunit *test);



void kunit_log_append(char *log, const char *fmt, ...);

void __printf(2, 3) kunit_log_append(char *log, const char *fmt, ...);



/*

 * printk and log to per-test or per-suite log buffer.  Logging only done

lib/kunit/string-stream.h

+3 −3
Original line number Diff line number Diff line
@@ -35,7 +35,7 @@ struct string_stream *alloc_string_stream(struct kunit *test, gfp_t gfp); 
int __printf(2, 3) string_stream_add(struct string_stream *stream,

				     const char *fmt, ...);



int string_stream_vadd(struct string_stream *stream,

int __printf(2, 0) string_stream_vadd(struct string_stream *stream,

				      const char *fmt,

				      va_list args);