Commit 44a48081 authored May 25, 2022 by Steve French

smb3: remove unneeded null check in cifs_readdir



Coverity pointed out an unneeded check.

Addresses-Coverity: 1518030 ("Null pointer dereferences")
Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: Steve French <stfrench@microsoft.com>

parent de3a9e94

fs/cifs/readdir.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -1105,10 +1105,8 @@ int cifs_readdir(struct file file, struct dir_context ctx)
		* find_cifs_entry in case there will be reconnects during
		* query_directory.
		*/
		if (cfid) {
		close_cached_dir(cfid);
		cfid = NULL;
		}

		cache_not_found:
		/*

fs/cifs/smb2ops.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -770,6 +770,7 @@ smb2_cached_lease_break(struct work_struct *work)
		/*
		* Open the and cache a directory handle.
		* Only supported for the root handle.
		* If error then *cfid is not initialized.
		*/
		int open_cached_dir(unsigned int xid, struct cifs_tcon *tcon,
		const char *path,